dallasgroot/Gimp
dallasgroot/Gimp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Issue #11592: do not strength-reduce pass-through groups with filters.

Browse source 
While the pass-through group can be skipped in some specific conditions,
this won't work with filters (then the effect would only apply to the
one layer child instead of applying to the result of the child
blended/composited with the bottom layers).

This inconsistency was quite visible because people had to create 2
layers and have one as non-Normal mode for it to behave as actual
pass-through group.
This commit is contained in:
Jehan 2025-03-01 22:23:52 +01:00
parent a1e5049f9f
commit 71aff49750
1 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
app/core/gimpgrouplayer.c
View file

@ -172,6 +172,8 @@ static void gimp_group_layer_convert_type (GimpLayer *layer,
GimpProgress *progress);
static GeglNode * gimp_group_layer_get_source_node (GimpDrawable *drawable);
static void gimp_group_layer_filters_changed (GimpDrawable *drawable);
static void gimp_group_layer_opacity_changed (GimpLayer *layer);
static void gimp_group_layer_effective_mode_changed (GimpLayer *layer);
static void
@ -301,6 +303,7 @@ gimp_group_layer_class_init (GimpGroupLayerClass *klass)
drawable_class->estimate_memsize = gimp_group_layer_estimate_memsize;
drawable_class->update_all = gimp_group_layer_update_all;
drawable_class->get_source_node = gimp_group_layer_get_source_node;
drawable_class->filters_changed = gimp_group_layer_filters_changed;
layer_class->opacity_changed = gimp_group_layer_opacity_changed;
layer_class->effective_mode_changed = gimp_group_layer_effective_mode_changed;
@ -1182,6 +1185,15 @@ gimp_group_layer_get_source_node (GimpDrawable *drawable)
return g_object_ref (private->source_node);
}
static void
gimp_group_layer_filters_changed (GimpDrawable *drawable)
{
gimp_layer_update_effective_mode (GIMP_LAYER (drawable));
if (GIMP_DRAWABLE_CLASS (parent_class)->filters_changed)
GIMP_DRAWABLE_CLASS (parent_class)->filters_changed (drawable);
}
static void
gimp_group_layer_opacity_changed (GimpLayer *layer)
{
@ -1275,6 +1287,7 @@ gimp_group_layer_get_effective_mode (GimpLayer *layer,
* cheaper.
*/
if (gimp_layer_get_mode (layer) == GIMP_LAYER_MODE_PASS_THROUGH &&
! gimp_drawable_has_visible_filters (GIMP_DRAWABLE (layer)) &&
! no_pass_through_strength_reduction)
{
/* we perform the strength-reduction if: