Issue #11653: Revise plug-in procedures that convert parameters from…

… legacy to gegl parameters.

This commit removed 57 legacy PDB procedures which were replacing
outdated plug-ins (before transformed into GEGL ops) as far as I
understand.

These were all kept only as a legacy compatibility layer for third-party
scripts. Since we are breaking API anyway, let's remove as many as we
can. I've only kept the few which are still used at least once in our
core scripts or plug-ins.

Now as pippin notes, we still have no easy way to quickly run GEGL ops
on drawables in script-fu. Though we have at least access to GEGL API
for C plug-ins and all GObject-Introspected bindings. But that's true
for all other ops anyway.

I guess what should happen (quickly-ish) after 3.0 release is a libgimp
utility function which does the heavy lifting of creating a GEGL graph
for us, and for script-fu probably a special-case binding or something.

app/pdb/internal-procs.c

@@ -30,7 +30,7 @@
 #include "internal-procs.h"
 
 
-/* 775 procedures registered total */
+/* 718 procedures registered total */
 
 void
 internal_procs_init (GimpPDB *pdb)

plug-ins/script-fu/scripts/unsharp-mask.scm

@@ -4,8 +4,7 @@
 ;;; Version 0.8
 
 ; This script-fu-unsharp-mask is not in the menus.
-; There is an equivalent GEGL filter at Filters>Enhance>Sharpen (Unsharp)
-; and a GEGL wrapper in the PDB, plug-in-unsharp-mask.
+; There is an equivalent GEGL filter at Filters>Enhance>Sharpen (Unsharp).
 ; This might be kept for compatibility and used by third party scripts.
 
 ; Seems not used by any script in the repo.

plug-ins/script-fu/test/tests/Plugins/gegl.scm

@@ -169,7 +169,6 @@
 ; in alphabetical order.
 (define gegl-wrapper-names
   (list
-    "alienmap2"
     "antialias"
     "apply-canvas"
     "applylens"
@@ -201,7 +200,6 @@
     "median-blur"
     "mosaic"
     "neon"
-    ; nova requires color arg that does not default
     "newsprint"
     "normalize"
     "oilify"
@@ -289,34 +287,6 @@
 (define (testSpecialGeglWrappers)
   (test! "Special test GEGL wrappers")
 
-  ; This is a typical, more elaborate test using sensical, not default, values.
-  ; Note that freq 0 produces little effect
-  (test! "alienmap2")
-  (testImageCreator)
-  (assert
-    `(plug-in-alienmap2
-        RUN-NONINTERACTIVE ,testImage ,testLayer
-        1 0 ; red freq, angle
-        1 0 ; green
-        1 0 ; blue
-        0 ; TODO what is the enum symbol RGB-MODEL ; color model
-        1 1 1 ;  RGB application modes
-        ; when script-fu-use-v3 #t #t #t
-        ))
-
-  ; Requires non-defaultable convolution matrix
-  (test! "convmatrix")
-  (testImageCreator)
-  (assert `(plug-in-convmatrix
-      RUN-NONINTERACTIVE ,testImage ,testLayer
-      #(1 2 3 4 5   1 2 3 4 5  1 2 3 4 5  1 2 3 4 5  1 2 3 4 5) ; conv matrix
-      0 0 0
-      #(1 0 1 0 1) ; channel mask
-      0 ; border mode
-      ))
-  (gimp-display-new testImage)
-  (gimp-displays-flush)
-
   ; Requires non-defaultable maps.
   ; We can never add test auto-defaulting the args.
   ; These are NOT the declared defaults.
@@ -331,57 +301,6 @@
       ))
   (gimp-display-new testImage)
   (gimp-displays-flush)
-
-  ; Requires non-defaultable maps
-  (test! "displace-polar")
-  (testImageCreator)
-  (assert `(plug-in-displace-polar
-      RUN-NONINTERACTIVE ,testImage ,testLayer
-      0 0 ; multiplier radial, tangent  default is -500
-      0 0 ; do displace x, y booleans
-      ,testLayer ,testLayer ; x, y maps
-      1 ; edge behaviour
-      ))
-  (gimp-display-new testImage)
-  (gimp-displays-flush)
-
-  ; Requires non-defaultable color
-  (test! "nova")
-  (testImageCreator)
-  (assert `(plug-in-nova
-      RUN-NONINTERACTIVE ,testImage ,testLayer
-      0 0 "red" ; other args defaulted
-      ))
-  (gimp-display-new testImage)
-  (gimp-displays-flush)
-
-  ; Requires non-defaultable color
-  (test! "papertile")
-  (testImageCreator)
-  (assert `(plug-in-papertile
-      RUN-NONINTERACTIVE ,testImage ,testLayer
-      1 ; tile size (width, height as one arg)
-      1.0 ; move rate
-      0 ; fractional type enum
-      0 0 ; wrap around, centering boolean
-      5  ; background type enum
-      "red" ; color when background type==5
-      ; other args defaulted
-      ))
-  (gimp-display-new testImage)
-  (gimp-displays-flush)
-
-  ; Requires non-defaultable color
-  (test! "sinus")
-  (testImageCreator)
-  (assert `(plug-in-sinus
-      RUN-NONINTERACTIVE ,testImage ,testLayer
-      0.1 0.1 ; x, y scale
-      0 0 0 0 0 "red" "green"
-      ; other args defaulted
-      ))
-  (gimp-display-new testImage)
-  (gimp-displays-flush)
 )