dallasgroot/Gimp
dallasgroot/Gimp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

plug-ins: plug-in-busy-dialog arguments should not depend on run-mode.

Browse source 
In INTERACTIVE or WITH_LAST_VALS modes, the arguments were replaced by
the latest values, which is typically not acceptable for this specific
plug-in. Even in interactive mode, we still want file descriptors to be
set explicitly, and used by the plug-in.

This fixes such error I had on terminal:

> (busy-dialog:193133): GLib-WARNING **: 20:34:43.692: ../glib/giounix.c:414Error while getting flags for FD: Bad file descriptor (9)

And the worst part was that it sometimes prevented the busy dialog from
quitting (though sometimes it still exited fine despite the wrong file
descriptors 🤷).

(cherry picked from commit 7374da53da)
This commit is contained in:
Jehan 2026-01-08 20:06:35 +01:00
parent b04893c08e
commit 6740842cab
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
plug-ins/common/busy-dialog.c
View file

@ -147,26 +147,29 @@ busy_dialog_create_procedure (GimpPlugIn *plug_in,
"The read file descriptor",
"The read file descriptor",
G_MININT, G_MAXINT, 0,
G_PARAM_READWRITE);
G_PARAM_READWRITE |
GIMP_PARAM_DONT_SERIALIZE);
gimp_procedure_add_int_argument (procedure, "write-fd",
"The write file descriptor",
"The write file descriptor",
G_MININT, G_MAXINT, 0,
G_PARAM_READWRITE);
G_PARAM_READWRITE |
GIMP_PARAM_DONT_SERIALIZE);
gimp_procedure_add_string_argument (procedure, "message",
"The message",
"The message",
NULL,
G_PARAM_READWRITE);
G_PARAM_READWRITE |
GIMP_PARAM_DONT_SERIALIZE);
gimp_procedure_add_boolean_argument (procedure, "cancelable",
"Whether the dialog is cancelable",
"Whether the dialog is cancelable",
FALSE,
G_PARAM_READWRITE);
G_PARAM_READWRITE |
GIMP_PARAM_DONT_SERIALIZE);
}
return procedure;