dallasgroot/Gimp
dallasgroot/Gimp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

plug-ins: improve describing enum and choice arguments.

Browse source 
* Also print the default value for both types of args.
* Display choice values with quotes since they are technically strings.
This commit is contained in:
Jehan 2026-03-06 22:49:14 +01:00
parent 7b4f0993e8
commit 635da347cd
1 changed files with 20 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
plug-ins/filter-browser/filter-browser.c
View file

@ -299,37 +299,49 @@ create_filter_param_details (GParamSpec *pspec,
help = (help != NULL ? g_markup_escape_text (help, -1) : NULL);
/* \xe2\x80\xa2 is the UTF-8 for the bullet point. */
if (help != NULL)
g_string_append_printf (desc, "\n\xe2\x80\xa2 <tt>%s</tt>: %s\n\t%s", nick, label, help);
g_string_append_printf (desc, "\n\xe2\x80\xa2 <tt>\"%s\"</tt>: %s\n\t%s", nick, label, help);
else
g_string_append_printf (desc, "\n\xe2\x80\xa2 <tt>%s</tt>: %s", nick, label);
g_string_append_printf (desc, "\n\xe2\x80\xa2 <tt>\"%s\"</tt>: %s", nick, label);
g_free (nick);
g_free (label);
g_free (help);
}
g_string_append_printf (blurb, "\n<tt><i>default:</i> \"%s\"</tt>",
gimp_param_spec_choice_get_default (pspec));
g_string_append (blurb, desc->str);
g_string_free (desc, TRUE);
}
if (g_type_is_a (gtype, G_TYPE_ENUM))
{
GEnumClass *eclass = NULL;
GType etype = 0;
const GValue *default_value;
GEnumClass *eclass = NULL;
GType etype = 0;
GString *desc = NULL;
etype = G_VALUE_TYPE (g_param_spec_get_default_value (pspec));
eclass = g_type_class_ref (etype);
default_value = g_param_spec_get_default_value (pspec);
etype = G_VALUE_TYPE (default_value);
eclass = g_type_class_ref (etype);
g_string_append_printf (blurb, "\n<i>%s</i>", _("Allowed values:"));
desc = g_string_new ("\n");
g_string_append_printf (desc, "<i>%s</i>", _("Allowed values:"));
for (guint i = 0; i < eclass->n_values; i++ )
{
GEnumValue value = eclass->values[i];
/* \xe2\x80\xa2 is the UTF-8 for the bullet point. */
g_string_append_printf (blurb, "\n\xe2\x80\xa2 <tt>%s</tt>: %s", value.value_name, value.value_nick);
g_string_append_printf (desc, "\n\xe2\x80\xa2 <tt>%s</tt>: %s", value.value_name, value.value_nick);
if (value.value == g_value_get_enum (default_value))
g_string_append_printf (blurb, "\n<tt><i>default:</i> %s</tt>", value.value_name);
}
g_string_append (blurb, desc->str);
g_string_free (desc, TRUE);
g_type_class_unref (eclass);
}