dallasgroot/Gimp
dallasgroot/Gimp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

file-data: Prevent crash with GIH and empty groups

Browse source 
Empty layer groups have no dimensions,
which can cause the GIH exporter to
crash when splitting cells (as it produces
negative width & height dimensions).

To prevent this, this patch initializes
potential brushes to NULL, verifies the
dimensions are positive before trying to
create GimpTempBuf with then, and prevents
a possible NULL brush from being added
to the exported brush list.
This commit is contained in:
Alx Sa 2026-03-09 16:21:30 +00:00
parent 413b24b0d4
commit 5b6f1b481a
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
app/file-data/file-data-gbr.c
View file

@ -275,6 +275,9 @@ file_gbr_drawable_to_brush (GimpDrawable *drawable,
width = rect->width;
height = rect->height;
if (width < 0 || height < 0)
return NULL;
brush = g_object_new (GIMP_TYPE_BRUSH,
"name", name,
"mime-type", "image/x-gimp-gbr",
@ -421,7 +424,7 @@ file_gbr_image_to_brush (GimpImage *image,
const gchar *name,
gdouble spacing)
{
GimpBrush *brush;
GimpBrush *brush = NULL;
GimpImage *subimage = NULL;
GimpDrawable *drawable;
gint width;

3
app/file-data/file-data-gih.c
View file

@ -346,7 +346,8 @@ file_gih_image_to_pipe (GimpImage *image,
gimp_object_get_name (layer),
spacing);
brushes = g_list_prepend (brushes, brush);
if (brush)
brushes = g_list_prepend (brushes, brush);
}
}
}