dallasgroot/Gimp
dallasgroot/Gimp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix #12344 PDF export crash w stack smash on flatpak

Browse source 
Fix overflowing RGB array on the stack.

Revise comments to say painting opaque.
This commit is contained in:
lloyd konneker 2024-11-13 07:38:06 -05:00 committed by Jehan
parent b9bee21683
commit 5b077a9232
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
plug-ins/common/file-pdf-export.c
View file

@ -761,8 +761,9 @@ pdf_export_image (GimpProcedure *procedure,
layers = gimp_image_get_layers (image);
n_layers = gimp_core_object_array_get_length ((GObject **) layers);
/* Fill image with background color if transparent and
* user chose that option.
/* First fill image with opaque background color
* when last layer has transparency and user chose that option.
* Later we paint the same layer and others layers with transparency.
*/
if (gimp_drawable_has_alpha (GIMP_DRAWABLE (layers[n_layers - 1])) &&
fill_background_color)
@ -774,7 +775,7 @@ pdf_export_image (GimpProcedure *procedure,
gimp_image_get_width (image),
gimp_image_get_height (image));
color = gimp_context_get_background ();
gegl_color_get_pixel (color, babl_format_with_space ("R'G'B'A double", NULL), rgb);
gegl_color_get_pixel (color, babl_format_with_space ("R'G'B' double", NULL), rgb);
cairo_set_source_rgb (cr, rgb[0], rgb[1], rgb[2]);
cairo_fill (cr);