dallasgroot/Gimp
dallasgroot/Gimp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

app, pdb: initialize the "config" object for custom GIMP operations.

Browse source 
If the config object is NULL, we later face crashes! My guess is that we
had only been testing editing custom ops, but not creating them from
public API!
This commit is contained in:
Jehan 2025-12-10 01:05:16 +01:00
parent 38c33eb6a0
commit 528cd1905a
2 changed files with 22 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
app/pdb/drawable-filter-cmds.c
View file

@ -165,6 +165,17 @@ drawable_filter_new_invoker (GimpProcedure *procedure,
gegl_node_set (operation,
"operation", operation_name,
NULL);
if (gimp_operation_config_is_custom (gimp, operation_name))
{
GParamSpec *pspec = gegl_node_find_property (operation, "config");
GType otype = pspec->value_type;
GObject *config = g_object_new (otype, NULL);
gegl_node_set (operation, "config", config, NULL);
g_object_unref (config);
}
filter = gimp_drawable_filter_new (drawable, name, operation, NULL);
/* We don't have a libgimp function for setting the clipping
* behavior. I want to look further into the whole logic first.

11
pdb/groups/drawable_filter.pdb
View file

@ -82,6 +82,17 @@ HELP
gegl_node_set (operation,
"operation", operation_name,
NULL);
if (gimp_operation_config_is_custom (gimp, operation_name))
{
GParamSpec *pspec = gegl_node_find_property (operation, "config");
GType otype = pspec->value_type;
GObject *config = g_object_new (otype, NULL);
gegl_node_set (operation, "config", config, NULL);
g_object_unref (config);
}
filter = gimp_drawable_filter_new (drawable, name, operation, NULL);
/* We don't have a libgimp function for setting the clipping
* behavior. I want to look further into the whole logic first.