From 3a9ab1c4193731a2bb77d6614e005253539bf95c Mon Sep 17 00:00:00 2001 From: Jehan Date: Sun, 1 Feb 2026 22:33:49 +0100 Subject: [PATCH] pdb: fix GIR annotation format for Deprecated tag. I just realized that the way we have been using "Deprecated:" tag was wrong. It has a version first, then further descriptive text. Fixes display "Deprecated since: Unknown" in gi-docgen documentation. --- pdb/lib.pl | 5 +++-- pdb/pdbgen.pl | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/pdb/lib.pl b/pdb/lib.pl index d47baf532e..cb72026f0c 100644 --- a/pdb/lib.pl +++ b/pdb/lib.pl @@ -550,6 +550,7 @@ CODE my $procdesc = ''; if ($proc->{deprecated}) { + $deprecated_since = $proc->{deprecated_since}; if ($proc->{deprecated} eq 'NONE') { if ($proc->{blurb}) { $procdesc = &desc_wrap($proc->{blurb}) . "\n *\n"; @@ -557,7 +558,7 @@ CODE if ($proc->{help}) { $procdesc .= &desc_wrap($proc->{help}) . "\n *\n"; } - $procdesc .= &desc_wrap("Deprecated: There is no replacement " . + $procdesc .= &desc_wrap("Deprecated: $deprecated_since: There is no replacement " . "for this procedure."); } else { @@ -583,7 +584,7 @@ CODE if ($proc->{help}) { $procdesc .= &desc_wrap($proc->{help}) . "\n *\n"; } - $procdesc .= &desc_wrap("Deprecated: " . + $procdesc .= &desc_wrap("Deprecated: $deprecated_since: " . "Use $replacement instead."); } } diff --git a/pdb/pdbgen.pl b/pdb/pdbgen.pl index 3c32115a99..3f96af9f30 100755 --- a/pdb/pdbgen.pl +++ b/pdb/pdbgen.pl @@ -67,8 +67,9 @@ $evalcode = <<'CODE'; }; # Variables to evaluate and insert into the PDB structure - my @procvars = qw($name $group $blurb $help $author $copyright $date $since - $deprecated @inargs @outargs %invoke $canonical_name + my @procvars = qw($name $group $blurb $help $author $copyright $date + $since $deprecated $deprecated_since + @inargs @outargs %invoke $canonical_name $lib_private $skip_gi); # These are attached to the group structure