From 34af64b70f05f188fc4e36337900abe2d7c068e6 Mon Sep 17 00:00:00 2001 From: Jehan Date: Sat, 10 Aug 2024 23:20:10 +0200 Subject: [PATCH] extensions, plug-ins: fixing CamelCase on the "Plug-In Examples" items. First of all: sorry to all translators who started working on these new strings! We use CamelCase for our titles, and in particular "Plug-In" is capitalized with 'I'. Furthermore, let's use understandable titles like "Plug-In Example in C" and not just "In C", because while the short title works OK in the menu, it makes for very broken action names in non-contextual parts of the software, such as the action search. Note that we in fact have a concept of short label for actions since commit 89772351c9. I added support for it to GEGL actions (cf. commit 6dc5f6792e), and to a few core actions (e.g. commit ea1205f094). Unfortunately I don't think I added an API yet for short label in plug-ins. Maybe I'll add it soon. But for now, if we have to have a single label, it should be long, so that it works in every situation. P.S.: not sure if it's useful to keep documentation strings just repeating the title, but for now, let's leave them. --- extensions/goat-exercises/goat-exercise-c.c | 6 +++--- extensions/goat-exercises/goat-exercise-gjs.js | 6 +++--- extensions/goat-exercises/goat-exercise-lua.lua | 6 +++--- extensions/goat-exercises/goat-exercise-py3.py | 6 +++--- extensions/goat-exercises/goat-exercise-vala.vala | 6 +++--- plug-ins/script-fu/scripts/test-sphere-v3.scm | 4 ++-- 6 files changed, 17 insertions(+), 17 deletions(-) diff --git a/extensions/goat-exercises/goat-exercise-c.c b/extensions/goat-exercises/goat-exercise-c.c index 5061456f62..f5fd6001df 100644 --- a/extensions/goat-exercises/goat-exercise-c.c +++ b/extensions/goat-exercises/goat-exercise-c.c @@ -111,10 +111,10 @@ goat_create_procedure (GimpPlugIn *plug_in, gimp_procedure_set_sensitivity_mask (procedure, GIMP_PROCEDURE_SENSITIVE_DRAWABLE); - gimp_procedure_set_menu_label (procedure, _("In _C")); + gimp_procedure_set_menu_label (procedure, _("Plug-In Example in _C")); gimp_procedure_set_icon_name (procedure, GIMP_ICON_GEGL); gimp_procedure_add_menu_path (procedure, - "/Filters/Development/Plug-in Examples/"); + "/Filters/Development/Plug-In Examples/"); gimp_procedure_set_documentation (procedure, _("Plug-in example in C"), @@ -177,7 +177,7 @@ goat_run (GimpProcedure *procedure, gint response; gimp_ui_init (PLUG_IN_BINARY); - dialog = gimp_dialog_new (_("Plug-in Example in C"), PLUG_IN_ROLE, + dialog = gimp_dialog_new (_("Plug-In Example in C"), PLUG_IN_ROLE, NULL, GTK_DIALOG_USE_HEADER_BAR, gimp_standard_help_func, PLUG_IN_PROC, diff --git a/extensions/goat-exercises/goat-exercise-gjs.js b/extensions/goat-exercises/goat-exercise-gjs.js index 7dc9256373..e82c1b0d66 100755 --- a/extensions/goat-exercises/goat-exercise-gjs.js +++ b/extensions/goat-exercises/goat-exercise-gjs.js @@ -60,9 +60,9 @@ var Goat = GObject.registerClass({ procedure.set_image_types("*"); procedure.set_sensitivity_mask(Gimp.ProcedureSensitivityMask.DRAWABLE); - procedure.set_menu_label(_("In _JavaScript")); + procedure.set_menu_label(_("Plug-In Example in _JavaScript")); procedure.set_icon_name(GimpUi.ICON_GEGL); - procedure.add_menu_path ('/Filters/Development/Plug-in Examples/'); + procedure.add_menu_path ('/Filters/Development/Plug-In Examples/'); procedure.set_documentation(_("Plug-in example in JavaScript (GJS)"), _("Plug-in example in JavaScript (GJS)"), @@ -87,7 +87,7 @@ var Goat = GObject.registerClass({ GimpUi.init("goat-exercise-gjs"); /* TODO: help function and ID. */ let dialog = new GimpUi.Dialog({ - title: _("Plug-in Example in JavaScript (GJS)"), + title: _("Plug-In Example in JavaScript (GJS)"), role: "goat-exercise-JavaScript", use_header_bar: true, }); diff --git a/extensions/goat-exercises/goat-exercise-lua.lua b/extensions/goat-exercises/goat-exercise-lua.lua index d0ec0a5c7c..d602c207a0 100755 --- a/extensions/goat-exercises/goat-exercise-lua.lua +++ b/extensions/goat-exercises/goat-exercise-lua.lua @@ -64,7 +64,7 @@ function run(procedure, run_mode, image, drawables, config, run_data) if run_mode == "INTERACTIVE" then GimpUi.init("goat-exercise-lua"); local dialog = GimpUi.Dialog { - title = _("Plug-in Example in Lua"), + title = _("Plug-In Example in Lua"), role = "goat-exercise-Lua", use_header_bar = 1 } @@ -169,9 +169,9 @@ function Goat.Exercise:do_create_procedure(name) procedure:set_image_types("*"); procedure:set_sensitivity_mask(Gimp.ProcedureSensitivityMask.DRAWABLE); - procedure:set_menu_label(_("In _Lua")); + procedure:set_menu_label(_("Plug-In Example in _Lua")); procedure:set_icon_name(GimpUi.ICON_GEGL); - procedure:add_menu_path('/Filters/Development/Plug-in Examples/'); + procedure:add_menu_path('/Filters/Development/Plug-In Examples/'); procedure:set_documentation(_("Plug-in example in Lua"), _("Plug-in example in Lua"), diff --git a/extensions/goat-exercises/goat-exercise-py3.py b/extensions/goat-exercises/goat-exercise-py3.py index 9c351a3c3d..366b443053 100755 --- a/extensions/goat-exercises/goat-exercise-py3.py +++ b/extensions/goat-exercises/goat-exercise-py3.py @@ -43,9 +43,9 @@ class Goat (Gimp.PlugIn): procedure.set_image_types("*") procedure.set_sensitivity_mask (Gimp.ProcedureSensitivityMask.DRAWABLE) - procedure.set_menu_label(_("In _Python")) + procedure.set_menu_label(_("Plug-In Example in _Python 3")) procedure.set_icon_name(GimpUi.ICON_GEGL) - procedure.add_menu_path('/Filters/Development/Plug-in Examples/') + procedure.add_menu_path('/Filters/Development/Plug-In Examples/') procedure.set_documentation(_("Plug-in example in Python 3"), _("Plug-in example in Python 3"), @@ -71,7 +71,7 @@ class Goat (Gimp.PlugIn): GimpUi.init("goat-exercise-py3.py") dialog = GimpUi.Dialog(use_header_bar=True, - title=_("Plug-in Example in Python 3"), + title=_("Plug-In Example in Python 3"), role="goat-exercise-Python3") dialog.add_button(_("_Cancel"), Gtk.ResponseType.CANCEL) diff --git a/extensions/goat-exercises/goat-exercise-vala.vala b/extensions/goat-exercises/goat-exercise-vala.vala index 62886899b8..bbb7148642 100755 --- a/extensions/goat-exercises/goat-exercise-vala.vala +++ b/extensions/goat-exercises/goat-exercise-vala.vala @@ -42,11 +42,11 @@ public class Goat : Gimp.PlugIn { var procedure = new Gimp.ImageProcedure(this, name, Gimp.PDBProcType.PLUGIN, this.run); procedure.set_image_types("RGB*, INDEXED*, GRAY*"); procedure.set_sensitivity_mask(Gimp.ProcedureSensitivityMask.DRAWABLE); - procedure.set_menu_label(_("In _Vala")); + procedure.set_menu_label(_("Plug-In Example in _Vala")); procedure.set_documentation(_("Plug-in example in Vala"), _("Plug-in example in Vala"), PLUG_IN_PROC); - procedure.add_menu_path("/Filters/Development/Plug-in Examples/"); + procedure.add_menu_path("/Filters/Development/Plug-In Examples/"); procedure.set_attribution("Niels De Graef", "Niels De Graef", "2020"); procedure.set_icon_name(GimpUi.ICON_GEGL); @@ -64,7 +64,7 @@ public class Goat : Gimp.PlugIn { GimpUi.init(PLUG_IN_BINARY); var dialog = - new GimpUi.Dialog(_("Plug-in Example in Vala"), + new GimpUi.Dialog(_("Plug-In Example in Vala"), PLUG_IN_ROLE, null, Gtk.DialogFlags.USE_HEADER_BAR, diff --git a/plug-ins/script-fu/scripts/test-sphere-v3.scm b/plug-ins/script-fu/scripts/test-sphere-v3.scm index 8a6a164d38..a5a0acf988 100644 --- a/plug-ins/script-fu/scripts/test-sphere-v3.scm +++ b/plug-ins/script-fu/scripts/test-sphere-v3.scm @@ -150,7 +150,7 @@ (script-fu-register-filter "script-fu-test-sphere-v3" ; Translator: this means "in the Scheme programming language" aka ScriptFu. - _"In _Scheme" + _"Plug-In Example in _Scheme" _"Plug-in example in Scheme" "Spencer Kimball, Sven Neumann" "Spencer Kimball" @@ -187,4 +187,4 @@ ) (script-fu-menu-register "script-fu-test-sphere-v3" - "/Filters/Development/Plug-in Examples") + "/Filters/Development/Plug-In Examples")