dallasgroot/Gimp
dallasgroot/Gimp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make all code paths result in a call to gtk_drag_finish() if we return

Browse source 
2008-03-30  Martin Nordholts  <martinn@svn.gnome.org>

	* app/widgets/gimpcontainertreeview-dnd.c
	(gimp_container_tree_view_drag_drop): Make all code paths result
	in a call to gtk_drag_finish() if we return TRUE. Fixes bug
	#317992.

svn path=/trunk/; revision=25320
This commit is contained in:
Martin Nordholts 2008-03-30 18:26:44 +00:00 committed by Martin Nordholts
parent e87bfe7a01
commit 16f4a5d5e0
2 changed files with 21 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
ChangeLog
View file

@ -1,3 +1,10 @@
2008-03-30 Martin Nordholts <martinn@svn.gnome.org>
* app/widgets/gimpcontainertreeview-dnd.c
(gimp_container_tree_view_drag_drop): Make all code paths result
in a call to gtk_drag_finish() if we return TRUE. Fixes bug
#317992.
2008-03-30 Sven Neumann <sven@gimp.org>
* app/core/gimparea.c (gimp_area_list_process): code cleanup.

17
app/widgets/gimpcontainertreeview-dnd.c
View file

@ -314,10 +314,21 @@ gimp_container_tree_view_drag_drop (GtkWidget *widget,
tree_view_class = GIMP_CONTAINER_TREE_VIEW_GET_CLASS (tree_view);
if (src_viewable)
tree_view_class->drop_viewable (tree_view, src_viewable,
dest_viewable, drop_pos);
{
gboolean success = TRUE;
/* XXX: Make GimpContainerTreeViewClass::drop_viewable()
* return success?
*/
tree_view_class->drop_viewable (tree_view, src_viewable,
dest_viewable, drop_pos);
gtk_drag_finish (context, success, FALSE, time);
}
else
gtk_drag_get_data (widget, context, target, time);
{
gtk_drag_get_data (widget, context, target, time);
}
return TRUE;
}