From 06d8bd6c54faed3338e9023d898a0b1f562fdd1d Mon Sep 17 00:00:00 2001 From: Bruno Lopes Date: Tue, 24 Mar 2026 08:50:19 -0300 Subject: [PATCH] build/windows: Do not allow cancelling itReinstall nor itUpdate As said on cbe2f6be, Inno does not support modifying installations at all, not even canceling/undoing modifications like reinstall and update. This limitation become more apparent after the fix 24e42dd1 so let's prevent the users being damaged by such major Inno pitfall. --- build/windows/installer/gimp-setup.iss | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/build/windows/installer/gimp-setup.iss b/build/windows/installer/gimp-setup.iss index 4010bec9a5..04932a80f6 100644 --- a/build/windows/installer/gimp-setup.iss +++ b/build/windows/installer/gimp-setup.iss @@ -2752,6 +2752,12 @@ begin case pCurStep of ssInstall: begin + //As on usUninstall, do not allow to cancel on itReinstall or itUpdate + //since Inno does not undo [InstallDelete] and RemoveDebugFiles() + if (InstallType = 'itReinstall') or (InstallType = 'itUpdate') then begin + WizardForm.CancelButton.Enabled := False; + end; + if IsAdminInstallMode() then begin RestorePoint(); end;