dallasgroot/Gimp
dallasgroot/Gimp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

widgets: Make GimpDoubleAction friendlier to GtkPadController

Browse source 
Handle some statefulness in actions taking a double parameter, in order
to make them friendly to GtkPadController and its pad ring/strip
integration.

The GtkPadController emits those actions with a double parameter
expressing the absolute value (e.g. 0-360 for rings, 0-1 for strips),
take care of converting these absolute values to relative changes
that increase/decrease the current GimpDoubleAction value.

Going for relative increments/decrements increases the genericity
of rings when mapped to actions, as going with the given absolute
values would mean means rings could be mainly mapped to angle-like
actions, reducing its usefulness.
This commit is contained in:
Carlos Garnacho 2023-07-02 19:51:58 +02:00 committed by Jehan
parent 0c3713b467
commit 058c19e5ac
1 changed files with 44 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

45
app/widgets/gimpdoubleaction.c
View file

@ -37,6 +37,14 @@ enum
PROP_VALUE
};
#define GET_PRIVATE(obj) (gimp_double_action_get_instance_private ((GimpDoubleAction *) (obj)))
typedef struct _GimpDoubleActionPrivate GimpDoubleActionPrivate;
struct _GimpDoubleActionPrivate
{
gdouble stateful_value;
};
static void gimp_double_action_g_action_iface_init (GActionInterface *iface);
@ -54,6 +62,7 @@ static void gimp_double_action_activate (GAction *action,
G_DEFINE_TYPE_WITH_CODE (GimpDoubleAction, gimp_double_action, GIMP_TYPE_ACTION_IMPL,
G_ADD_PRIVATE (GimpDoubleAction)
G_IMPLEMENT_INTERFACE (G_TYPE_ACTION, gimp_double_action_g_action_iface_init))
#define parent_class gimp_double_action_parent_class
@ -78,6 +87,9 @@ gimp_double_action_class_init (GimpDoubleActionClass *klass)
static void
gimp_double_action_init (GimpDoubleAction *action)
{
GimpDoubleActionPrivate *private = GET_PRIVATE (action);
private->stateful_value = -1;
}
static void
@ -155,7 +167,38 @@ static void
gimp_double_action_activate (GAction *action,
GVariant *parameter)
{
GimpDoubleAction *double_action = GIMP_DOUBLE_ACTION (action);
GimpDoubleAction *double_action = GIMP_DOUBLE_ACTION (action);
GimpDoubleActionPrivate *private = GET_PRIVATE (double_action);
/* Handle double parameters in a way friendly to GtkPadController */
if (g_variant_is_of_type (parameter, G_VARIANT_TYPE_DOUBLE))
{
double value = g_variant_get_double (parameter);
double delta;
double new_value;
if (private->stateful_value < 0)
{
/* Initial event */
delta = 0;
new_value = value;
}
else if (private->stateful_value == value)
{
/* Last (stop) event */
delta = 0;
new_value = -1;
}
else
{
/* Intermediate event */
delta = (private->stateful_value < value) ? 1 : -1;
new_value = value;
}
double_action->value += delta;
private->stateful_value = new_value;
}
gimp_action_emit_activate (GIMP_ACTION (action),
g_variant_new_double (double_action->value));