From 01af0f78c87ae8f3d4863524f63591b9708035be Mon Sep 17 00:00:00 2001
From: Alx Sa <cmyk.student@gmail.com>
Date: Tue, 24 Sep 2024 22:56:44 +0000
Subject: [PATCH] app, libgimp, pdb: Fix generation warnings

On generating our PDB files, we were
getting warnings about uninitialized strings.
This is because descriptions and authors
had been left off three .pdb files. Adding
these in resolved the warnings.
A new PDB author entry was also added
for Idriss Fekir.
---
 app/pdb/font-cmds.c              | 6 +++---
 app/pdb/fonts-cmds.c             | 6 +++---
 libgimp/gimpdrawableselect_pdb.c | 2 +-
 libgimp/gimpfont_pdb.c           | 2 ++
 libgimp/gimpfonts_pdb.c          | 2 ++
 pdb/groups/drawable_select.pdb   | 1 +
 pdb/groups/font.pdb              | 2 ++
 pdb/groups/fonts.pdb             | 2 ++
 pdb/stddefs.pdb                  | 4 ++++
 9 files changed, 20 insertions(+), 7 deletions(-)

diff --git a/app/pdb/font-cmds.c b/app/pdb/font-cmds.c
index a95dcc64b8..919d220a5d 100644
--- a/app/pdb/font-cmds.c
+++ b/app/pdb/font-cmds.c
@@ -166,9 +166,9 @@ register_font_procs (GimpPDB *pdb)
                                   "Retrieve the font lookup name.",
                                   NULL);
   gimp_procedure_set_static_attribution (procedure,
-                                         "",
-                                         "",
-                                         "");
+                                         "Idriss Fekir",
+                                         "Idriss Fekir",
+                                         "2023");
   gimp_procedure_add_argument (procedure,
                                gimp_param_spec_font ("font",
                                                      "font",
diff --git a/app/pdb/fonts-cmds.c b/app/pdb/fonts-cmds.c
index f15160953c..431f085ec6 100644
--- a/app/pdb/fonts-cmds.c
+++ b/app/pdb/fonts-cmds.c
@@ -178,9 +178,9 @@ register_fonts_procs (GimpPDB *pdb)
                                   "This procedure returns custom FontConfig configs along with the fonts renaming config.",
                                   NULL);
   gimp_procedure_set_static_attribution (procedure,
-                                         "",
-                                         "",
-                                         "");
+                                         "Idriss Fekir",
+                                         "Idriss Fekir",
+                                         "2023");
   gimp_procedure_add_return_value (procedure,
                                    gimp_param_spec_string ("config",
                                                            "config",
diff --git a/libgimp/gimpdrawableselect_pdb.c b/libgimp/gimpdrawableselect_pdb.c
index 9a6a817c2b..4defd2a4cd 100644
--- a/libgimp/gimpdrawableselect_pdb.c
+++ b/libgimp/gimpdrawableselect_pdb.c
@@ -32,7 +32,7 @@
  * @title: gimpdrawableselect
  * @short_description: Methods of a drawable chooser dialog
  *
-
+ * Methods of a drawable chooser dialog
  **/
 
 
diff --git a/libgimp/gimpfont_pdb.c b/libgimp/gimpfont_pdb.c
index 4b52a5865e..8a7e9909fc 100644
--- a/libgimp/gimpfont_pdb.c
+++ b/libgimp/gimpfont_pdb.c
@@ -46,6 +46,8 @@
  *
  * Returns: (transfer full): font lookup name.
  *          The returned value must be freed with g_free().
+ *
+ * Since: 3.0
  **/
 gchar *
 _gimp_font_get_lookup_name (GimpFont *font)
diff --git a/libgimp/gimpfonts_pdb.c b/libgimp/gimpfonts_pdb.c
index 2a6bc8f794..e6f079c046 100644
--- a/libgimp/gimpfonts_pdb.c
+++ b/libgimp/gimpfonts_pdb.c
@@ -82,6 +82,8 @@ gimp_fonts_refresh (void)
  *
  * Returns: (transfer full): config path.
  *          The returned value must be freed with g_free().
+ *
+ * Since: 3.0
  **/
 gchar *
 _gimp_fonts_get_custom_configs (gchar  **sysconfig,
diff --git a/pdb/groups/drawable_select.pdb b/pdb/groups/drawable_select.pdb
index 99c55e6a21..8d4b848e3b 100644
--- a/pdb/groups/drawable_select.pdb
+++ b/pdb/groups/drawable_select.pdb
@@ -109,5 +109,6 @@ CODE
 $desc = 'Drawables UI';
 $doc_title = 'gimpdrawableselect';
 $doc_short_desc = 'Methods of a drawable chooser dialog';
+$doc_long_desc = 'Methods of a drawable chooser dialog';
 
 1;
diff --git a/pdb/groups/font.pdb b/pdb/groups/font.pdb
index 882727949d..6609149f8b 100644
--- a/pdb/groups/font.pdb
+++ b/pdb/groups/font.pdb
@@ -109,6 +109,8 @@ sub font_get_lookup_name {
 Retrieve the font lookup name.
 HELP
 
+    &idriss_pdb_misc('2023', '3.0');
+
     $lib_private = 1;
 
     @inargs = (
diff --git a/pdb/groups/fonts.pdb b/pdb/groups/fonts.pdb
index 32778fed8e..c4b8652ff1 100644
--- a/pdb/groups/fonts.pdb
+++ b/pdb/groups/fonts.pdb
@@ -80,6 +80,8 @@ sub fonts_get_custom_configs {
 This procedure returns custom FontConfig configs along with the fonts renaming config.
 HELP
 
+    &idriss_pdb_misc('2023', '3.0');
+
     $lib_private = 1;
 
     @inargs = (
diff --git a/pdb/stddefs.pdb b/pdb/stddefs.pdb
index df90b9a8eb..73f8b241bd 100644
--- a/pdb/stddefs.pdb
+++ b/pdb/stddefs.pdb
@@ -173,6 +173,10 @@ sub alxsa_pdb_misc {
     contrib_pdb_misc('Alex S.', '', @_);
 }
 
+sub idriss_pdb_misc {
+    contrib_pdb_misc('Idriss Fekir', '', @_);
+}
+
 sub std_pdb_deprecated {
     if (@_) {
         $blurb = $help = '';