From f11db750368e287d47e6f099a69ec0ab3b4ecc7f Mon Sep 17 00:00:00 2001 From: systemBlue Date: Thu, 4 Jun 2026 08:55:56 -0400 Subject: [PATCH] test: assert filter summary is hidden by default and shown for a non-default scope --- Forji/ForjiUITests/IssueUITests.swift | 8 ++++---- Forji/ForjiUITests/PullRequestUITests.swift | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/Forji/ForjiUITests/IssueUITests.swift b/Forji/ForjiUITests/IssueUITests.swift index 29ffd33..3beb4f5 100644 --- a/Forji/ForjiUITests/IssueUITests.swift +++ b/Forji/ForjiUITests/IssueUITests.swift @@ -37,17 +37,17 @@ final class IssueUITests: ForgejoReadOnlyUITestBase { // Wait for list to load XCTAssertTrue(app.cells.firstMatch.waitForExistence(timeout: 10), "Issues should load") - // Default filter summary should show "Open" (default scope is All involvement) + // In the default state (Open + All involvement) the summary is hidden. let filterSummary = app.staticTexts["filter-summary"] - XCTAssertTrue(filterSummary.waitForExistence(timeout: 5)) - XCTAssertEqual(filterSummary.label, "Open") + XCTAssertFalse(filterSummary.exists, "Filter summary should be hidden in the default state") let filterMenuButton = app.buttons["filter-menu-button"] - // Tap "Assigned to you" via filter menu + // Selecting a non-default scope reveals the summary. filterMenuButton.tap() app.buttons["Assigned to you"].tap() sleep(2) + XCTAssertTrue(filterSummary.waitForExistence(timeout: 5)) XCTAssertTrue(filterSummary.label.contains("Assigned to you")) // Tap "Mentioned" via filter menu diff --git a/Forji/ForjiUITests/PullRequestUITests.swift b/Forji/ForjiUITests/PullRequestUITests.swift index b9d727f..7e2b82f 100644 --- a/Forji/ForjiUITests/PullRequestUITests.swift +++ b/Forji/ForjiUITests/PullRequestUITests.swift @@ -111,17 +111,17 @@ final class PullRequestUITests: ForgejoReadOnlyUITestBase { // Reset filters to defaults (previous test may have changed them) resetOverviewFilters() - // Default filter summary should show "Open" (default scope is All involvement) + // In the default state (Open + All involvement) the summary is hidden. let filterSummary = app.staticTexts["filter-summary"] - XCTAssertTrue(filterSummary.waitForExistence(timeout: 5)) - XCTAssertEqual(filterSummary.label, "Open") + XCTAssertFalse(filterSummary.exists, "Filter summary should be hidden in the default state") let filterMenuButton = app.buttons["filter-menu-button"] - // Tap "Assigned to you" via filter menu + // Selecting a non-default scope reveals the summary. filterMenuButton.tap() app.buttons["Assigned to you"].tap() sleep(2) + XCTAssertTrue(filterSummary.waitForExistence(timeout: 5)) XCTAssertTrue(filterSummary.label.contains("Assigned to you")) // Tap "Mentioned" via filter menu