diff --git a/Forji/Forji/Views/CommentView.swift b/Forji/Forji/Views/CommentView.swift index 5453740..48a3e24 100644 --- a/Forji/Forji/Views/CommentView.swift +++ b/Forji/Forji/Views/CommentView.swift @@ -36,6 +36,7 @@ struct CommentView: View { .foregroundStyle(.secondary) } .buttonStyle(.plain) + .accessibilityLabel("Edit comment") } } diff --git a/Forji/Forji/Views/FileViewerView.swift b/Forji/Forji/Views/FileViewerView.swift index 295faf6..e714550 100644 --- a/Forji/Forji/Views/FileViewerView.swift +++ b/Forji/Forji/Views/FileViewerView.swift @@ -113,6 +113,7 @@ struct FileViewerView: View { } label: { Image(systemName: "pencil") } + .accessibilityLabel("Edit file") .accessibilityIdentifier("file-edit-button") } } diff --git a/Forji/Forji/Views/FloatingButtons.swift b/Forji/Forji/Views/FloatingButtons.swift index af60d98..0b2a9a6 100644 --- a/Forji/Forji/Views/FloatingButtons.swift +++ b/Forji/Forji/Views/FloatingButtons.swift @@ -11,6 +11,7 @@ struct FloatingCreateButton: View { .frame(width: 56, height: 56) } .glassEffect(.regular.tint(.blue).interactive()) + .accessibilityLabel("Create") .padding(.trailing, 20) .padding(.bottom, 20) } @@ -36,6 +37,7 @@ struct ExpandableActionMenu: View { .frame(width: 40, height: 40) } .buttonStyle(.glass) + .accessibilityLabel("Actions") .accessibilityIdentifier("action-menu-toggle") .accessibilityValue(isExpanded ? "expanded" : "collapsed") } diff --git a/Forji/Forji/Views/InstanceListView.swift b/Forji/Forji/Views/InstanceListView.swift index 588917c..0e657ca 100644 --- a/Forji/Forji/Views/InstanceListView.swift +++ b/Forji/Forji/Views/InstanceListView.swift @@ -79,6 +79,7 @@ struct InstanceListView: View { } label: { Image(systemName: "plus") } + .accessibilityLabel("Add instance") .accessibilityIdentifier("instance-add-button") } } @@ -129,6 +130,7 @@ struct InstanceListView: View { .foregroundStyle(.secondary) } .buttonStyle(.plain) + .accessibilityLabel("Edit instance") .accessibilityIdentifier("instance-edit-button") } } diff --git a/Forji/Forji/Views/MarkdownComponents.swift b/Forji/Forji/Views/MarkdownComponents.swift index 4675157..bf61bed 100644 --- a/Forji/Forji/Views/MarkdownComponents.swift +++ b/Forji/Forji/Views/MarkdownComponents.swift @@ -64,22 +64,23 @@ private struct MarkdownToolbar: View { var body: some View { ScrollView(.horizontal, showsIndicators: false) { HStack(spacing: 12) { - toolbarButton("bold", icon: "bold") { wrap("**") } - toolbarButton("italic", icon: "italic") { wrap("_") } - toolbarButton("heading", icon: "number") { prefix("# ") } - toolbarButton("code", icon: "chevron.left.forwardslash.chevron.right") { wrap("`") } - toolbarButton("codeblock", icon: "text.page") { wrapBlock("```") } - toolbarButton("link", icon: "link") { insertLink() } - toolbarButton("list", icon: "list.bullet") { prefix("- ") } - toolbarButton("quote", icon: "text.quote") { prefix("> ") } - toolbarButton("task", icon: "checklist") { prefix("- [ ] ") } + toolbarButton("bold", icon: "bold", label: "Bold") { wrap("**") } + toolbarButton("italic", icon: "italic", label: "Italic") { wrap("_") } + toolbarButton("heading", icon: "number", label: "Heading") { prefix("# ") } + toolbarButton("code", icon: "chevron.left.forwardslash.chevron.right", + label: "Inline code") { wrap("`") } + toolbarButton("codeblock", icon: "text.page", label: "Code block") { wrapBlock("```") } + toolbarButton("link", icon: "link", label: "Insert link") { insertLink() } + toolbarButton("list", icon: "list.bullet", label: "Bulleted list") { prefix("- ") } + toolbarButton("quote", icon: "text.quote", label: "Quote") { prefix("> ") } + toolbarButton("task", icon: "checklist", label: "Task list") { prefix("- [ ] ") } } .padding(.horizontal, 8) .padding(.vertical, 6) } } - private func toolbarButton(_ id: String, icon: String, action: @escaping () -> Void) -> some View { + private func toolbarButton(_ id: String, icon: String, label: String, action: @escaping () -> Void) -> some View { Button(action: action) { Image(systemName: icon) .font(.subheadline) @@ -88,6 +89,7 @@ private struct MarkdownToolbar: View { } .buttonStyle(.plain) .foregroundStyle(.primary) + .accessibilityLabel(label) .accessibilityIdentifier("markdown-toolbar-\(id)") } diff --git a/Forji/Forji/Views/RepositoryDetailView.swift b/Forji/Forji/Views/RepositoryDetailView.swift index 022d50f..f7c735f 100644 --- a/Forji/Forji/Views/RepositoryDetailView.swift +++ b/Forji/Forji/Views/RepositoryDetailView.swift @@ -211,6 +211,7 @@ struct RepositoryDetailView: View { } label: { Image(systemName: "clock.arrow.circlepath") } + .accessibilityLabel("Commit history") .accessibilityIdentifier("commits-button") } } diff --git a/Forji/Forji/Views/RepositoryListView.swift b/Forji/Forji/Views/RepositoryListView.swift index 8f99aae..ae7ea5a 100644 --- a/Forji/Forji/Views/RepositoryListView.swift +++ b/Forji/Forji/Views/RepositoryListView.swift @@ -280,6 +280,7 @@ struct RepositoryRow: View { } .buttonStyle(.borderless) .disabled(isStarring) + .accessibilityLabel(isStarred ? "Unstar repository" : "Star repository") .accessibilityIdentifier("star-button") } diff --git a/Forji/Forji/Views/WorkflowRunDetailView.swift b/Forji/Forji/Views/WorkflowRunDetailView.swift index ed6f0cf..8ed91f4 100644 --- a/Forji/Forji/Views/WorkflowRunDetailView.swift +++ b/Forji/Forji/Views/WorkflowRunDetailView.swift @@ -48,6 +48,7 @@ struct WorkflowRunDetailView: View { Link(destination: parsed) { Image(systemName: "safari") } + .accessibilityLabel("Open in browser") .accessibilityIdentifier("workflow-run-open-browser") } }