mirror of
https://gitea.wildfiregames.com/0ad/0ad
synced 2026-06-16 13:23:56 -07:00
3028551b91
Introduce MOVABLE idiom indicating that a class can use move semantics. Make values of CGUI struct maps holding XML data const to ensure at the root that the data is not modified. Use NONCOPYABLE and MOVABLE for SGUIIcon and SGUIStyle to enforce the non-copy policy on the compiler level (until someone changes the GUI design to make modifications needed). As indicated by that: Replace copy operations by in place move operations for these CGUI struct maps in the CGUI Xeromyces XML loading functions. Replace copy operations by const references for CSize and SGUIIcon in CGUIString::GenerateTextCall and CGUI::GenerateText. This avoids copying of non primitive members, such as the strings and containers of strings. Further related cleanup to be kept separated for auditability. Differential Revision: https://code.wildfiregames.com/D2163 Few comments on IRC by: wraitii, Itms Tested on: gcc 9, Jenkins, partially VS2015 Refs #1984, NONCOPYABLE CGUISpriteInstances:0a7d0ecdde,8f4f8e240f,c19f3608a5NONCOPYABLE Image, Sprite:fb8032043bNONCOPYABLE GUI page:94c57085e9NONCOPYABLE GUIManager:7c2e9027c2NONCOPYABLE macro:16ccae10cdThis was SVN commit r22637.
69 lines
1.8 KiB
C++
69 lines
1.8 KiB
C++
/* Copyright (C) 2019 Wildfire Games.
|
|
* This file is part of 0 A.D.
|
|
*
|
|
* 0 A.D. is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* 0 A.D. is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with 0 A.D. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "precompiled.h"
|
|
|
|
#include "CGUISprite.h"
|
|
|
|
CGUISprite::~CGUISprite()
|
|
{
|
|
for (SGUIImage* const& img : m_Images)
|
|
delete img;
|
|
}
|
|
|
|
void CGUISprite::AddImage(SGUIImage* image)
|
|
{
|
|
m_Images.push_back(image);
|
|
}
|
|
|
|
void CGUISpriteInstance::Draw(const CRect& Size, int CellID, std::map<CStr, const CGUISprite*>& Sprites, float Z) const
|
|
{
|
|
if (m_CachedSize != Size || m_CachedCellID != CellID)
|
|
{
|
|
GUIRenderer::UpdateDrawCallCache(m_DrawCallCache, m_SpriteName, Size, CellID, Sprites);
|
|
m_CachedSize = Size;
|
|
m_CachedCellID = CellID;
|
|
}
|
|
GUIRenderer::Draw(m_DrawCallCache, Z);
|
|
}
|
|
|
|
bool CGUISpriteInstance::IsEmpty() const
|
|
{
|
|
return m_SpriteName.empty();
|
|
}
|
|
|
|
// Plus a load of constructors / assignment operators, which don't copy the
|
|
// DrawCall cache (to avoid losing track of who has allocated various bits
|
|
// of data):
|
|
|
|
CGUISpriteInstance::CGUISpriteInstance()
|
|
: m_CachedCellID(-1)
|
|
{
|
|
}
|
|
|
|
CGUISpriteInstance::CGUISpriteInstance(const CStr& SpriteName)
|
|
: m_SpriteName(SpriteName), m_CachedCellID(-1)
|
|
{
|
|
}
|
|
|
|
void CGUISpriteInstance::SetName(const CStr& SpriteName)
|
|
{
|
|
m_SpriteName = SpriteName;
|
|
m_CachedSize = CRect();
|
|
m_DrawCallCache.clear();
|
|
m_CachedCellID = -1;
|
|
}
|