mirror of
https://gitea.wildfiregames.com/0ad/0ad
synced 2026-06-16 05:13:58 -07:00
a7694ef8b3
The UPnP implementation included a combination of two subtle bugs, which resulted in failure to create port forwardings every time after the first one. When using UPnP, the internet gateway to create the port forwardings at needs to discovered. As that takes a while, the its root descriptor URL was supposed to be cached after successful discovery in the user config in "network.upnprootdescurl". However, instead of caching the root descriptor URL, the control URL got cached. That caused following requests to the root descriptor URL to fail, as they ended up at the control URL instead. As such requests might also fail when the network topology changed, the code was supposed to fall back to discovering the internet gateway again when the cached one didn't work. However, due to the inner workings of miniupnpc the request using the cached root descriptor URL didn't result in an error, so the new discovery was never triggered. As the wrong value was persisted in the user config there was also no way to get out of this situation again. This commit fixes both of these bugs. As far as I can tell these bugs existed since the introduction of the caching of the root descriptor URL in |
||
|---|---|---|
| .. | ||
| scripting | ||
| tests | ||
| FSM.h | ||
| NetClient.cpp | ||
| NetClient.h | ||
| NetClientTurnManager.cpp | ||
| NetClientTurnManager.h | ||
| NetEnet.cpp | ||
| NetEnet.h | ||
| NetFileTransfer.cpp | ||
| NetFileTransfer.h | ||
| NetHost.cpp | ||
| NetHost.h | ||
| NetMessage.cpp | ||
| NetMessage.h | ||
| NetMessages.h | ||
| NetMessageSim.cpp | ||
| NetServer.cpp | ||
| NetServer.h | ||
| NetServerTurnManager.cpp | ||
| NetServerTurnManager.h | ||
| NetSession.cpp | ||
| NetSession.h | ||
| NetStats.cpp | ||
| NetStats.h | ||
| NMTCreator.h | ||
| Serialization.h | ||
| StringConverters.h | ||
| StunClient.cpp | ||
| StunClient.h | ||