mirror of
https://gitea.wildfiregames.com/0ad/0ad
synced 2026-06-20 23:33:59 -07:00
Make include-what-you-use happy with some files in source/lib and fix what needs to be fixed. Ref: #8086 Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
117 lines
5.3 KiB
C++
117 lines
5.3 KiB
C++
/* Copyright (C) 2025 Wildfire Games.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining
|
|
* a copy of this software and associated documentation files (the
|
|
* "Software"), to deal in the Software without restriction, including
|
|
* without limitation the rights to use, copy, modify, merge, publish,
|
|
* distribute, sublicense, and/or sell copies of the Software, and to
|
|
* permit persons to whom the Software is furnished to do so, subject to
|
|
* the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included
|
|
* in all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
|
|
* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
|
|
* CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
|
|
* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
|
|
* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
*/
|
|
|
|
#include "lib/self_test.h"
|
|
|
|
#include "lib/file/archive/archive.h"
|
|
#include "lib/file/archive/archive_zip.h"
|
|
#include "lib/file/file_system.h"
|
|
#include "lib/file/io/io.h"
|
|
#include "lib/file/vfs/vfs_path.h"
|
|
#include "lib/os_path.h"
|
|
#include "lib/path.h"
|
|
#include "lib/status.h"
|
|
|
|
#include <cstdint>
|
|
#include <iterator>
|
|
#include <string>
|
|
|
|
namespace
|
|
{
|
|
// Implementation of the static buffer used to communicate with ArchiveEntryCallback
|
|
std::string g_ResultBuffer;
|
|
|
|
static OsPath MOD_PATH(DataDir() / "mods" / "_test.lib" / "");
|
|
}
|
|
|
|
class TestArchiveZip : public CxxTest::TestSuite
|
|
{
|
|
public:
|
|
void setUp()
|
|
{
|
|
if(DirectoryExists(MOD_PATH))
|
|
DeleteDirectory(MOD_PATH);
|
|
}
|
|
|
|
void tearDown()
|
|
{
|
|
DeleteDirectory(MOD_PATH);
|
|
}
|
|
|
|
void test_scan_suspiciousZipFile()
|
|
{
|
|
OsPath testDir = MOD_PATH / "file" / "archive";
|
|
OsPath testPath = testDir / "test.zip";
|
|
|
|
// Hexdump of a zip archive with a comment at the end
|
|
const unsigned char cbTestZip[] = {
|
|
0x50, 0x4b, 0x03, 0x04, 0x14, 0x00, 0x00, 0x00, 0x08, 0x00, 0x5a, 0xb6, 0xba, 0x4c, 0xf4, 0x84,
|
|
0x59, 0xea, 0x70, 0x00, 0x00, 0x00, 0xae, 0x00, 0x00, 0x00, 0x16, 0x00, 0x1c, 0x00, 0x62, 0x75,
|
|
0x69, 0x6c, 0x64, 0x7a, 0x69, 0x70, 0x77, 0x69, 0x74, 0x68, 0x63, 0x6f, 0x6d, 0x6d, 0x65, 0x6e,
|
|
0x74, 0x2e, 0x73, 0x68, 0x55, 0x54, 0x09, 0x00, 0x03, 0xac, 0xc8, 0x09, 0x5b, 0xaf, 0xc8, 0x09,
|
|
0x5b, 0x75, 0x78, 0x0b, 0x00, 0x01, 0x04, 0xe8, 0x03, 0x00, 0x00, 0x04, 0x64, 0x00, 0x00, 0x00,
|
|
0x4d, 0x8d, 0x5d, 0x0a, 0x83, 0x30, 0x0c, 0xc7, 0xdf, 0x7b, 0x8a, 0xa8, 0x6f, 0x03, 0xdb, 0x0b,
|
|
0x0c, 0x4f, 0xe1, 0x05, 0x5a, 0xcd, 0xd6, 0x80, 0x26, 0x65, 0xc9, 0x10, 0x76, 0xfa, 0x55, 0x64,
|
|
0x74, 0x6f, 0x3f, 0xfe, 0x9f, 0x43, 0x17, 0x12, 0x71, 0xd0, 0xec, 0x3e, 0x54, 0xc0, 0x50, 0xcd,
|
|
0x9f, 0x70, 0xf3, 0x55, 0xf1, 0xa1, 0x22, 0x8b, 0x61, 0xd3, 0xa7, 0x0b, 0x6d, 0x2f, 0x0e, 0x97,
|
|
0x2c, 0xd0, 0xcf, 0x99, 0x14, 0x1e, 0xb4, 0x21, 0x2c, 0xc2, 0x16, 0x89, 0x15, 0x22, 0xfc, 0x6a,
|
|
0x2b, 0xee, 0xc2, 0x6a, 0xaf, 0x68, 0x24, 0x0c, 0x07, 0x59, 0xae, 0x66, 0x11, 0x55, 0x4a, 0xb5,
|
|
0x90, 0xde, 0xcf, 0x1e, 0xa6, 0xbf, 0xc5, 0xf6, 0x37, 0x1e, 0xed, 0xf2, 0xde, 0x02, 0xee, 0x0b,
|
|
0x50, 0x4b, 0x01, 0x02, 0x1e, 0x03, 0x14, 0x00, 0x00, 0x00, 0x08, 0x00, 0x5a, 0xb6, 0xba, 0x4c,
|
|
0xf4, 0x84, 0x59, 0xea, 0x70, 0x00, 0x00, 0x00, 0xae, 0x00, 0x00, 0x00, 0x16, 0x00, 0x18, 0x00,
|
|
0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0xed, 0x81, 0x00, 0x00, 0x00, 0x00, 0x62, 0x75,
|
|
0x69, 0x6c, 0x64, 0x7a, 0x69, 0x70, 0x77, 0x69, 0x74, 0x68, 0x63, 0x6f, 0x6d, 0x6d, 0x65, 0x6e,
|
|
0x74, 0x2e, 0x73, 0x68, 0x55, 0x54, 0x05, 0x00, 0x03, 0xac, 0xc8, 0x09, 0x5b, 0x75, 0x78, 0x0b,
|
|
0x00, 0x01, 0x04, 0xe8, 0x03, 0x00, 0x00, 0x04, 0x64, 0x00, 0x00, 0x00, 0x50, 0x4b, 0x05, 0x06,
|
|
0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x01, 0x00, 0x5c, 0x00, 0x00, 0x00, 0xc0, 0x00, 0x00, 0x00,
|
|
0x3e, 0x00, 0x54, 0x68, 0x69, 0x73, 0x20, 0x66, 0x69, 0x6c, 0x65, 0x20, 0x63, 0x6f, 0x6e, 0x74,
|
|
0x61, 0x69, 0x6e, 0x73, 0x20, 0x61, 0x20, 0x7a, 0x69, 0x70, 0x6e, 0x6f, 0x74, 0x65, 0x20, 0x64,
|
|
0x65, 0x6d, 0x6f, 0x6e, 0x73, 0x74, 0x72, 0x61, 0x74, 0x69, 0x6f, 0x6e, 0x20, 0x77, 0x69, 0x74,
|
|
0x68, 0x20, 0x61, 0x20, 0x70, 0x6f, 0x73, 0x73, 0x69, 0x62, 0x6c, 0x65, 0x20, 0x62, 0x75, 0x67};
|
|
|
|
// HACK: This test case requires a sample zip archive with
|
|
// a comment at the end. Since SVN patches cannot
|
|
// contain binary data, the sample archive is stored
|
|
// as a hexdump above and written to the file system
|
|
// as the test executes.
|
|
TS_ASSERT_EQUALS(INFO::OK, CreateDirectories(testDir, 0700, false));
|
|
// Note: This file write access has to be done synchronously,
|
|
// as the following statement expects the file to be
|
|
// present and complete
|
|
TS_ASSERT_EQUALS(INFO::OK, io::Store(testPath, cbTestZip, std::size(cbTestZip)));
|
|
|
|
PIArchiveReader testee = CreateArchiveReader_Zip(testPath);
|
|
TS_ASSERT_DIFFERS(nullptr, testee);
|
|
|
|
g_ResultBuffer = "";
|
|
TS_ASSERT_EQUALS(INFO::OK, testee->ReadEntries(TestArchiveZip::ArchiveEntryCallback, 0));
|
|
|
|
TS_ASSERT_EQUALS("buildzipwithcomment.sh", g_ResultBuffer);
|
|
}
|
|
|
|
private:
|
|
static void ArchiveEntryCallback(const VfsPath& path, const CFileInfo&, PIArchiveFile,
|
|
uintptr_t /*cbData*/)
|
|
{
|
|
g_ResultBuffer = path.string8();
|
|
}
|
|
};
|