0ad/source/ps/GameSetup
wraitii 87a2c3347f Make real directory paths on the VFS predictable (retry)
This is the same commit as 4bb31f084e, reverted in 5d1899785a. Noted
issues were fixed.

Partial revert/fix of 2f19cf86d3 and 2567fee329.

Before this diff, it was possible for a mod containing a cache/ or a
config/ folder to get written to incorrectly.
The issue is VFS can map multiple directories to one 'virtual' path, for
reading mods. However, writing data is problematic: which path to
choose?
The only viable solution is to use a path relative to the highest
priority directory encountered in the VFS path, or write paths could be
'hijacked' by lower-priority mods.

This fixes these issues by:
- Adding a new lookup mode ('Real-path') that explicitly picks the real
path relative to the highest-priority subdirectory in the VFS Path.
- Preventing overwriting a real directory with a lower priority one in
general.
- Revert c0c8132dd4's GetRealPath change, re-introducing the function as
GetOriginalPath.

This also cleans up some duplication that led to empty mod folders in
the user mod path, and cleans up loading the 'user' mod.
It also makes it explicit that a directory must be passed to Mount().

Note that the new 'realpath' lookup can still be somewhat complex with
many mount points at various hierarchy levels, but it is at least
predictable/deterministic without having to be careful about populating
order.

Fixes #2553

Differential Revision: https://code.wildfiregames.com/D3728
This was SVN commit r25107.
2021-03-23 12:46:59 +00:00
..
tests Add a mod installer, fixes #4027. 2018-04-15 01:46:28 +00:00
Atlas.cpp Add the ability to specify a log level when using dlopen and change it to normal for Atlas. 2014-06-05 17:07:04 +00:00
Atlas.h Add basic help page into the main menu. 2010-07-07 21:47:31 +00:00
CmdLineArgs.cpp Add a mod installer, fixes #4027. 2018-04-15 01:46:28 +00:00
CmdLineArgs.h Further header & precompiled cleanup, fix no-PCH builds. 2020-12-09 14:39:14 +00:00
Config.cpp Refactor HWDetect and rendering options setup. 2020-06-07 13:16:57 +00:00
Config.h Refactor HWDetect and rendering options setup. 2020-06-07 13:16:57 +00:00
GameSetup.cpp Make real directory paths on the VFS predictable (retry) 2021-03-23 12:46:59 +00:00
GameSetup.h Address concerns in 5473393e30 (RL interface) 2021-01-15 16:30:05 +00:00
HWDetect.cpp Fixes revealed missed include after e104b41be2. 2021-03-04 08:55:49 +00:00
HWDetect.h Add script-based system for doing messy stuff based on system configuration. 2010-11-20 19:46:49 +00:00
Paths.cpp Actually remove trailing whitespace for non-header files as well. 2016-11-23 13:02:58 +00:00
Paths.h Updates data paths on OS X and Windows. On OS X only write to locations inside ~/Library. On Windows make the distinction between local and roaming appdata, and use folder inside My Documents for user-created data. Fixes #1145. 2012-03-22 00:23:31 +00:00