0ad/source/scriptinterface
trompetin17 5b8cb7f34b
Support std::optional in FromJSVal
This commit introduces support for std::optional<T> in
Script::FromJSVal. When a JavaScript value is undefined or null, the
resulting optional is set to std::nullopt; otherwise, the value is
converted and wrapped.

This change allows components to cleanly handle optional script values
without needing manual null checks or exception handling in C++.

As a direct application of this feature, the Identity component now uses
std::optional<std::wstring> for the return value of GetCiv(). This
resolves a bug where formation templates (e.g., those inheriting from
template_formation.xml) do not explicitly define a civ. After commit
03f7903fec, the code assumed GetCiv() would always return a valid
string, leading to undefined behavior when it was missing.

With this update:
- GetCiv() returning undefined results in an empty optional.
- The Identity component defaults to an empty civilization string ("")
  when the civ is not defined.
- This avoids crashes or actor parsing errors for civ-less templates and
  improves robustness in script-C++ interaction.

Closes: #8107
Fixes: #8091
2025-06-19 08:52:24 -05:00
..
tests Test whether some files are reloaded more directly 2025-06-18 14:42:13 +02:00
FunctionWrapper.h Improve error logging for failed JS-to-C++ script conversions 2025-06-19 08:52:23 -05:00
JSON.cpp Revert non-ASCII characters from source and configuration files introduced in 157c6af18e. 2023-12-03 00:30:12 +00:00
JSON.h Revert non-ASCII characters from source and configuration files introduced in 157c6af18e. 2023-12-03 00:30:12 +00:00
ModuleLoader.cpp Disalow importing some files 2025-06-06 17:36:35 +02:00
ModuleLoader.h Disalow importing some files 2025-06-06 17:36:35 +02:00
Object.h Skip redundant HasProperty in GetObjectClassName 2025-05-10 17:08:49 +02:00
Promises.cpp Add final to classes introduced in f9114a87f2 2024-08-25 13:38:09 +02:00
Promises.h Upgrade SpiderMonkey to ESR 115 2024-12-09 10:46:12 +01:00
ScriptContext.cpp Remove the name of some unused arguments 2025-06-18 12:49:59 +02:00
ScriptContext.h Stop running shrinking gcs & simplify GC logic. 2025-04-22 17:03:29 +02:00
ScriptConversions.cpp Remove the name of some unused arguments 2025-06-18 12:49:59 +02:00
ScriptConversions.h Support std::optional in FromJSVal 2025-06-19 08:52:24 -05:00
ScriptEngine.h Revert non-ASCII characters from source and configuration files introduced in 157c6af18e. 2023-12-03 00:30:12 +00:00
ScriptExceptions.cpp Revert non-ASCII characters from source and configuration files introduced in 157c6af18e. 2023-12-03 00:30:12 +00:00
ScriptExceptions.h Revert non-ASCII characters from source and configuration files introduced in 157c6af18e. 2023-12-03 00:30:12 +00:00
ScriptExtraHeaders.h Upgrade SpiderMonkey to ESR 115 2024-12-09 10:46:12 +01:00
ScriptForward.h Upgrade SpiderMonkey to ESR 115 2024-12-09 10:46:12 +01:00
ScriptInterface.cpp Disalow importing some files 2025-06-06 17:36:35 +02:00
ScriptInterface.h Disalow importing some files 2025-06-06 17:36:35 +02:00
ScriptRequest.h Revert non-ASCII characters from source and configuration files introduced in 157c6af18e. 2023-12-03 00:30:12 +00:00
ScriptStats.cpp Revert non-ASCII characters from source and configuration files introduced in 157c6af18e. 2023-12-03 00:30:12 +00:00
ScriptStats.h Revert non-ASCII characters from source and configuration files introduced in 157c6af18e. 2023-12-03 00:30:12 +00:00
ScriptTypes.h Remove check for SpiderMonkey minor version 2024-12-09 10:46:14 +01:00
StructuredClone.cpp Revert non-ASCII characters from source and configuration files introduced in 157c6af18e. 2023-12-03 00:30:12 +00:00
StructuredClone.h Revert non-ASCII characters from source and configuration files introduced in 157c6af18e. 2023-12-03 00:30:12 +00:00