From f0faab7a42f60ef448b09c1ea8f15d0ac2ba016e Mon Sep 17 00:00:00 2001 From: wraitii Date: Mon, 28 Dec 2020 17:44:20 +0000 Subject: [PATCH] Fix serialization errors when hosting MP game. Follows D2746 / 9fc6c3c897 and dad2857538. Player colors are copied from the settings, which are deep-frozen, thus not extensible. Cloning them restores that, allowing serialization. Reported By: Angen Differential Revision: https://code.wildfiregames.com/D3263 This was SVN commit r24466. --- .../GameSettings/PerPlayer/Dropdowns/PlayerColor.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSettings/PerPlayer/Dropdowns/PlayerColor.js b/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSettings/PerPlayer/Dropdowns/PlayerColor.js index be4e19481d..bedf9542af 100644 --- a/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSettings/PerPlayer/Dropdowns/PlayerColor.js +++ b/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSettings/PerPlayer/Dropdowns/PlayerColor.js @@ -48,7 +48,7 @@ PlayerSettingControls.PlayerColor = class extends GameSettingControlDropdown smallestDistance = distance; } } - this.values.push(closestColor); + this.values.push(clone(closestColor)); } this.dropdown.list = this.values.map(color => coloredText(this.ColorIcon, rgbToGuiColor(color)));