From dba968013fc78cf71fba2531837e8ea46bb30a1d Mon Sep 17 00:00:00 2001 From: Vladislav Belov Date: Mon, 16 Dec 2024 23:18:20 +0100 Subject: [PATCH] Fixes Vulkan device selection. According to #6936 some lower devices (especially virtual ones) might report more memory than regular ones. So we can't use the memory amount as a score for now. --- source/renderer/backend/vulkan/DeviceSelection.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/source/renderer/backend/vulkan/DeviceSelection.cpp b/source/renderer/backend/vulkan/DeviceSelection.cpp index 7e5690b5d7..90d94aaece 100644 --- a/source/renderer/backend/vulkan/DeviceSelection.cpp +++ b/source/renderer/backend/vulkan/DeviceSelection.cpp @@ -323,10 +323,6 @@ bool ComparePhysicalDevices( const uint32_t deviceTypeScore2 = GetDeviceTypeScore(device2.properties.deviceType); if (deviceTypeScore1 != deviceTypeScore2) return deviceTypeScore1 > deviceTypeScore2; - // We use a total device memory amount to compare. We assume that more memory - // means better performance as previous metrics are equal. - if (device1.deviceTotalMemory != device2.deviceTotalMemory) - return device1.deviceTotalMemory > device2.deviceTotalMemory; return device1.index < device2.index; }