From 8aea8d08491635bd37e77f7f763311bf3624f64c Mon Sep 17 00:00:00 2001 From: elexis Date: Thu, 16 Jun 2016 00:40:21 +0000 Subject: [PATCH] Replace magic number with a readable string, refs #3436. This was SVN commit r18388. --- .../data/mods/public/gui/replaymenu/replay_filters.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/binaries/data/mods/public/gui/replaymenu/replay_filters.js b/binaries/data/mods/public/gui/replaymenu/replay_filters.js index a4a3836767..e7969d5412 100644 --- a/binaries/data/mods/public/gui/replaymenu/replay_filters.js +++ b/binaries/data/mods/public/gui/replaymenu/replay_filters.js @@ -237,8 +237,9 @@ function filterReplay(replay) // Filter by singleplayer / multiplayer let singleplayerFilter = Engine.GetGUIObjectByName("singleplayerFilter"); - if (singleplayerFilter.selected == 1 && replay.isMultiplayer || - singleplayerFilter.selected == 2 && !replay.isMultiplayer) + let selectedSingleplayerFilter = singleplayerFilter.list_data[singleplayerFilter.selected] || ""; + if (selectedSingleplayerFilter == "Singleplayer" && replay.isMultiplayer || + selectedSingleplayerFilter == "Multiplayer" && !replay.isMultiplayer) return false; // Filter by victory condition @@ -248,8 +249,9 @@ function filterReplay(replay) // Filter by rating let ratedGamesFilter = Engine.GetGUIObjectByName("ratedGamesFilter"); - if (ratedGamesFilter.selected == 1 && !replay.isRated || - ratedGamesFilter.selected == 2 && replay.isRated) + let selectedRatedGamesFilter = ratedGamesFilter.list_data[ratedGamesFilter.selected] || ""; + if (selectedRatedGamesFilter == "rated" && !replay.isRated || + selectedRatedGamesFilter == "not rated" && replay.isRated) return false // Filter date/time (select a month)