Delete wrongful proxy CGUIManager::GetPreDefinedColor from f0d9806b3f.
It is wrong because the predefined colors should be loaded from the GUI
page that requests to have the color parsed, which may be different from
the topmost page.
Similar to FindObjectByName removed in f9b529f2fb.
Achieve this by implementing the CGUISetting<CGUIColor>::FromJSVal
specialization, moved from ScriptInterface::FromJSVal<CGUIColor>,
instead of adding a CGUI pointer to CGUIColor.
Mark ScriptInterface::FromJSVal<GUIColor> and inherited
CColor::ParseString explicitly as deleted, so that people get a compile
error if they forget to check for predefined colors when parsing a
color.
Refs #5387, D1746 > D1684 > this > f9b529f2fb, 9be8a560a9, 415939b59b,
2c47fbd66a, 85a622b13a.
Differential Revision: https://code.wildfiregames.com/D2108
Tested on: clang 8, VS2015
This was SVN commit r22663.
2019-08-13 11:00:41 -07:00
|
|
|
/* Copyright (C) 2019 Wildfire Games.
|
2013-11-02 07:39:08 -07:00
|
|
|
* This file is part of 0 A.D.
|
|
|
|
|
*
|
|
|
|
|
* 0 A.D. is free software: you can redistribute it and/or modify
|
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
|
* the Free Software Foundation, either version 2 of the License, or
|
|
|
|
|
* (at your option) any later version.
|
|
|
|
|
*
|
|
|
|
|
* 0 A.D. is distributed in the hope that it will be useful,
|
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
|
*
|
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
|
* along with 0 A.D. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#include "lib/self_test.h"
|
|
|
|
|
|
2019-10-02 02:44:00 -07:00
|
|
|
#include "gui/SettingTypes/CGUISize.h"
|
2019-08-29 02:07:29 -07:00
|
|
|
#include "gui/CGUI.h"
|
2014-05-24 20:16:52 -07:00
|
|
|
#include "ps/CLogger.h"
|
2013-11-02 07:39:08 -07:00
|
|
|
|
2016-11-23 03:18:37 -08:00
|
|
|
class TestGuiParseString : public CxxTest::TestSuite
|
2013-11-02 07:39:08 -07:00
|
|
|
{
|
|
|
|
|
public:
|
2019-10-01 08:06:13 -07:00
|
|
|
void test_guisize()
|
2013-11-02 07:39:08 -07:00
|
|
|
{
|
2014-05-24 20:16:52 -07:00
|
|
|
TestLogger nolog;
|
2019-10-01 08:06:13 -07:00
|
|
|
CGUISize size;
|
2013-11-02 07:39:08 -07:00
|
|
|
|
2014-05-24 20:16:52 -07:00
|
|
|
// Test only pixels
|
2019-10-01 08:06:13 -07:00
|
|
|
TS_ASSERT(size.FromString("0.0 -10 20.0 -30"));
|
|
|
|
|
TS_ASSERT_EQUALS(size, CGUISize(CRect(0, -10, 20, -30), CRect(0, 0, 0, 0)));
|
2013-11-02 07:39:08 -07:00
|
|
|
|
2014-05-24 20:16:52 -07:00
|
|
|
// Test only pixels, but with math
|
2019-10-01 08:06:13 -07:00
|
|
|
TS_ASSERT(size.FromString("0 -100-10+100 20+200-200 -30"));
|
|
|
|
|
TS_ASSERT_EQUALS(size, CGUISize(CRect(0, -10, 20, -30), CRect(0, 0, 0, 0)));
|
2013-11-02 07:39:08 -07:00
|
|
|
|
2014-05-24 20:16:52 -07:00
|
|
|
// Test only percent
|
2019-10-01 08:06:13 -07:00
|
|
|
TS_ASSERT(size.FromString("-5% 10.0% -20% 30.0%"));
|
|
|
|
|
TS_ASSERT_EQUALS(size, CGUISize(CRect(0, 0, 0, 0), CRect(-5, 10, -20, 30)));
|
2013-11-02 07:39:08 -07:00
|
|
|
|
2014-05-24 20:16:52 -07:00
|
|
|
// Test only percent, but with math
|
2019-10-01 08:06:13 -07:00
|
|
|
TS_ASSERT(size.FromString("15%-5%-15% 10% -20% 30%+500%-500%"));
|
|
|
|
|
TS_ASSERT_EQUALS(size, CGUISize(CRect(0, 0, 0, 0), CRect(-5, 10, -20, 30)));
|
2013-11-02 07:39:08 -07:00
|
|
|
|
2014-05-24 20:16:52 -07:00
|
|
|
// Test mixed
|
2019-10-01 08:06:13 -07:00
|
|
|
TS_ASSERT(size.FromString("5% -10 -20% 30"));
|
|
|
|
|
TS_ASSERT_EQUALS(size, CGUISize(CRect(0, -10, 0, 30), CRect(5, 0, -20, 0)));
|
2014-05-24 20:16:52 -07:00
|
|
|
|
|
|
|
|
// Test mixed with math
|
2019-10-01 08:06:13 -07:00
|
|
|
TS_ASSERT(size.FromString("5%+10%-10% 30%-10-30% 50-20%-50 30-100+100"));
|
|
|
|
|
TS_ASSERT_EQUALS(size, CGUISize(CRect(0, -10, 0, 30), CRect(5, 0, -20, 0)));
|
2014-05-24 20:16:52 -07:00
|
|
|
|
|
|
|
|
// Test for fail with too many/few parameters
|
2019-10-01 08:06:13 -07:00
|
|
|
TS_ASSERT(!size.FromString("10 20 30 40 50"));
|
|
|
|
|
TS_ASSERT(!size.FromString("10 20 30"));
|
2014-05-24 20:16:52 -07:00
|
|
|
|
|
|
|
|
// Test for fail with garbage data
|
2019-10-01 08:06:13 -07:00
|
|
|
TS_ASSERT(!size.FromString("Hello world!"));
|
|
|
|
|
TS_ASSERT(!size.FromString("abc 123 xyz 789"));
|
|
|
|
|
TS_ASSERT(!size.FromString("300 wide, 400 high"));
|
2014-05-24 20:16:52 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void test_rect()
|
|
|
|
|
{
|
|
|
|
|
TestLogger nolog;
|
|
|
|
|
CRect test;
|
|
|
|
|
|
2019-08-29 02:07:29 -07:00
|
|
|
TS_ASSERT(CGUI::ParseString<CRect>(nullptr, CStrW(L"0.0 10.0 20.0 30.0"), test));
|
2014-05-24 20:16:52 -07:00
|
|
|
TS_ASSERT_EQUALS(CRect(0.0, 10.0, 20.0, 30.0), test);
|
|
|
|
|
|
2019-08-29 02:07:29 -07:00
|
|
|
TS_ASSERT(!CGUI::ParseString<CRect>(nullptr, CStrW(L"0 10 20"), test));
|
|
|
|
|
TS_ASSERT(!CGUI::ParseString<CRect>(nullptr, CStrW(L"0 10 20 30 40"), test));
|
|
|
|
|
TS_ASSERT(!CGUI::ParseString<CRect>(nullptr, CStrW(L"0,0 10,0 20,0 30,0"), test));
|
2014-05-24 20:16:52 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void test_size()
|
|
|
|
|
{
|
|
|
|
|
TestLogger nolog;
|
|
|
|
|
CSize test;
|
|
|
|
|
|
2019-08-29 02:07:29 -07:00
|
|
|
TS_ASSERT(CGUI::ParseString<CSize>(nullptr, CStrW(L"0.0 10.0"), test));
|
2014-05-24 20:16:52 -07:00
|
|
|
TS_ASSERT_EQUALS(CSize(0.0, 10.0), test);
|
|
|
|
|
|
2019-08-29 02:07:29 -07:00
|
|
|
TS_ASSERT(!CGUI::ParseString<CSize>(nullptr, CStrW(L"0"), test));
|
|
|
|
|
TS_ASSERT(!CGUI::ParseString<CSize>(nullptr, CStrW(L"0 10 20"), test));
|
|
|
|
|
TS_ASSERT(!CGUI::ParseString<CSize>(nullptr, CStrW(L"0,0 10,0"), test));
|
2014-05-24 20:16:52 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void test_pos()
|
|
|
|
|
{
|
|
|
|
|
TestLogger nolog;
|
|
|
|
|
CPos test;
|
|
|
|
|
|
2019-08-29 02:07:29 -07:00
|
|
|
TS_ASSERT(CGUI::ParseString<CPos>(nullptr, CStrW(L"0.0 10.0"), test));
|
2014-05-24 20:16:52 -07:00
|
|
|
TS_ASSERT_EQUALS(CPos(0.0, 10.0), test);
|
|
|
|
|
|
2019-08-29 02:07:29 -07:00
|
|
|
TS_ASSERT(!CGUI::ParseString<CPos>(nullptr, CStrW(L"0"), test));
|
|
|
|
|
TS_ASSERT(!CGUI::ParseString<CPos>(nullptr, CStrW(L"0 10 20"), test));
|
|
|
|
|
TS_ASSERT(!CGUI::ParseString<CPos>(nullptr, CStrW(L"0,0 10,0"), test));
|
2013-11-02 07:39:08 -07:00
|
|
|
}
|
|
|
|
|
};
|